Skip to content

handle rate limiter & github server-side errors#63

Open
mredolatti wants to merge 7 commits intosinger-io:masterfrom
mredolatti:fix/handle_rate_limiter
Open

handle rate limiter & github server-side errors#63
mredolatti wants to merge 7 commits intosinger-io:masterfrom
mredolatti:fix/handle_rate_limiter

Conversation

@mredolatti
Copy link

@mredolatti mredolatti commented May 24, 2019

Two issues were found while using this library:

  • Random and isolated 502 errors from github make the whole job fail.
  • If the number of API calls exceeds github's limit, the whole job fails.

To deal with these scenarios, simple retry logic was added, and in the case of a rate limiting situation, we wait until the next reset time to move forward with the next retry.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.